logbot: images disappeared, missing "src" #39

New Issue

mb · 2023-07-12T12:17:55+02:00

mb commented

2023-07-12 12:17:55 +02:00

Hey hey, super nice to see the caption feature! It really adds a new dimension to the logs!

I bumped into it because i found this log page that Martino and i sporadically use for a project for Constant that we're working on, and some of the images have disappeared: https://vvvvvvaria.org/logs/dislog/

It seems that only the images that are sent after the introduction of the caption feature still work? The ones that are sent before seem to all disappear once a new item is added to the log by the logbot.

I digged a bit into the commit of the caption feature, and saw that in the template data_url is used: b33d4f173d (diff-2) This might be causing it, because older images don't have a data_url stored in the .json file database (see screenshot), which seems to make them disappear?

Can we think of a way to make a fallback for the older images, so that both new and old work? That would be nice :).

Hey hey, super nice to see the caption feature! It really adds a new dimension to the logs! I bumped into it because i found this log page that Martino and i sporadically use for a project for Constant that we're working on, and some of the images have disappeared: https://vvvvvvaria.org/logs/dislog/ It seems that only the images that are sent after the introduction of the caption feature still work? The ones that are sent before seem to all disappear once a new item is added to the log by the logbot. I digged a bit into the commit of the caption feature, and saw that in the template `data_url` is used: https://git.vvvvvvaria.org/varia/bots/commit/b33d4f173d2bb09719c3fb0d00d1a4ad7bcf4c9e#diff-2 This might be causing it, because older images don't have a `data_url` stored in the `.json` file database (see screenshot), which seems to make them disappear? Can we think of a way to make a fallback for the older images, so that both new and old work? That would be nice :).

Screenshot from 2023-07-12 12-13-16.png

38 KiB

Sign in to join this conversation.

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: varia/bots#39