logbot: Curious to understand why the template writing was reverted back to homebrewing style? #9

Open
opened 3 years ago by mb · 2 comments
mb commented 3 years ago

In this commit: 57c2dbc881

In this commit: https://git.vvvvvvaria.org/varia/bots/commit/57c2dbc8815860c61790a96cc7defee50218bafe
Owner

I ran into the issues I guess you also ran into ;)

I opened up https://github.com/decentral1se/xbotlib/issues/15.

Didn't have time to come back to this but xbotlib doesn't handle this smoothly yet. What I see as the issue is that it looks for the stylesheet.css in the --output directory but that isn't where that file is in this case of the logbot. So, there is maybe a case for a --stylesheet option to make sure the path can be set to pick it up.

I ran into the issues I guess you also ran into ;) I opened up https://github.com/decentral1se/xbotlib/issues/15. Didn't have time to come back to this but `xbotlib` doesn't handle this smoothly yet. What I see as the issue is that it looks for the `stylesheet.css` in the `--output` directory but that isn't where that file is in this case of the logbot. So, there is maybe a case for a `--stylesheet` option to make sure the path can be set to pick it up.
mb commented 3 years ago
Poster

Nice yes! That can go hand in hand with an option to switch stylesheets! :) --> #8.

And yes, i bumped into issues with self.template indeed, can't remember the exact details, but i couldn't figure it out. That's why i was using Jinja in the end. But it would be great if that could be skipped!

Nice yes! That can go hand in hand with an option to switch stylesheets! :) --> https://git.vvvvvvaria.org/varia/bots/issues/8. And yes, i bumped into issues with self.template indeed, can't remember the exact details, but i couldn't figure it out. That's why i was using Jinja in the end. But it would be great if that could be skipped!
mb changed title from Curious to understand why the template writing was reverted back to homebrewing style? to logbot: Curious to understand why the template writing was reverted back to homebrewing style? 3 years ago
Sign in to join this conversation.
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.