varia/etherpump
14
0
Fork 0
Code Issues 15 Pull Requests Releases Activity

the raw.html files are saving a completely different file #11

New Issue
Open
opened 2020-11-20 18:55:53 +01:00 by mb · 4 comments
mb commented 2020-11-20 18:55:53 +01:00
Copy Link

I am totally not following what is happening, see https://vvvvvvaria.org/etherpump/ for a non-working index.

I am totally not following what is happening, see https://vvvvvvaria.org/etherpump/ for a non-working index.
mb commented 2020-11-20 23:18:06 +01:00
Author
Copy Link

Found the source of the bug: line 450 in commands/pull.py

See below a manually printed API request:

  • with the first padID added in manually by me
  • and the second being assigned to it through the code somewhere

https://pad.vvvvvvaria.org/api/1.2.9/getHTML?padID=heatwave_reviews&apikey=XXX&padID=Overkill_End_of_Physical&startRev=0

They don't match.

Found the source of the bug: line 450 in commands/pull.py See below a manually printed API request: - with the first padID added in manually by me - and the second being assigned to it through the code somewhere https://pad.vvvvvvaria.org/api/1.2.9/getHTML?padID=heatwave_reviews&apikey=XXX&padID=Overkill_End_of_Physical&startRev=0 They don't match.
mb commented 2020-11-20 23:31:10 +01:00
Author
Copy Link

Solved it in a hacky way for now, see commands/pull.py line 450 and further.

Despite the hackiness, i also feel proud to be fixing my very first bug in someone else's code :---).

Solved it in a hacky way for now, see commands/pull.py line 450 and further. Despite the hackiness, i also feel proud to be fixing my very first bug in someone else's code :---).
decentral1se commented 2020-12-05 09:39:54 +01:00
Owner
Copy Link

Wonderful 💌

Seems #16 is related then!

Still needs some digging...

Wonderful 💌 Seems https://git.vvvvvvaria.org/varia/etherpump/issues/16 is related then! Still needs some digging...
decentral1se commented 2020-12-10 18:01:42 +01:00
Owner
Copy Link

Seems like this comment is the solution then. Sooo, to close this off then I guess we should somehow detect in the try/catch block if the exception is thrown because of a "Failed to download" error and then stop the execution and say that maybe you are overpowering the Etherpad installation and use a lower --connection setting. Also, we could drop the default to 10 to help avoid this.

Seems like [this comment](https://git.vvvvvvaria.org/varia/etherpump/issues/16#issuecomment-136) is the solution then. Sooo, to close this off then I guess we should somehow detect in the try/catch block if the exception is thrown because of a "Failed to download" error and then stop the execution and say that maybe you are overpowering the Etherpad installation and use a lower `--connection` setting. Also, we could drop the default to `10` to help avoid this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: varia/etherpump#11
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?