Found the source of the bug: line 450 in commands/pull.py
See below a manually printed API request:
- with the first padID added in manually by me
- and the second being assigned to it through the code somewhere
https://pad.vvvvvvaria.org/api/1.2.9/getHTML?padID=heatwave_reviews&apikey=XXX&padID=Overkill_End_of_Physical&startRev=0
They don't match.
Solved it in a hacky way for now, see commands/pull.py line 450 and further.
Despite the hackiness, i also feel proud to be fixing my very first bug in someone else's code :---).
Solved it in a hacky way for now, see commands/pull.py line 450 and further.
Despite the hackiness, i also feel proud to be fixing my very first bug in someone else's code :---).
Seems like this comment is the solution then. Sooo, to close this off then I guess we should somehow detect in the try/catch block if the exception is thrown because of a "Failed to download" error and then stop the execution and say that maybe you are overpowering the Etherpad installation and use a lower --connection setting. Also, we could drop the default to 10 to help avoid this.
Seems like [this comment](https://git.vvvvvvaria.org/varia/etherpump/issues/16#issuecomment-136) is the solution then. Sooo, to close this off then I guess we should somehow detect in the try/catch block if the exception is thrown because of a "Failed to download" error and then stop the execution and say that maybe you are overpowering the Etherpad installation and use a lower `--connection` setting. Also, we could drop the default to `10` to help avoid this.
I am totally not following what is happening, see https://vvvvvvaria.org/etherpump/ for a non-working index.
Found the source of the bug: line 450 in commands/pull.py
See below a manually printed API request:
https://pad.vvvvvvaria.org/api/1.2.9/getHTML?padID=heatwave_reviews&apikey=XXX&padID=Overkill_End_of_Physical&startRev=0
They don't match.
Solved it in a hacky way for now, see commands/pull.py line 450 and further.
Despite the hackiness, i also feel proud to be fixing my very first bug in someone else's code :---).
Wonderful 💌
Seems #16 is related then!
Still needs some digging...
Seems like this comment is the solution then. Sooo, to close this off then I guess we should somehow detect in the try/catch block if the exception is thrown because of a "Failed to download" error and then stop the execution and say that maybe you are overpowering the Etherpad installation and use a lower
--connection
setting. Also, we could drop the default to10
to help avoid this.