approach SimpleDatabase with care ... #2

New Issue

mb · 2021-02-17T14:14:00+01:00

mb commented

2021-02-17 14:14:00 +01:00

@decentral1se: "watch out for that SimpleDatabase, there are some secret bugs! you always need to run _dumps() when you want to be sure to save because of an obsure behaviour in python"

decentral1se commented

2021-02-17 15:42:06 +01:00

An example of having some logic which always force a _dumps() call is here fa80d094a7/xbotlib.py (L559). I think if you have a db = SimpleDatabase() and then you do db['a'] = [] and then db['a'].append(1) then the .append doesn't trigger a _dumps() call. You have to do it yourself.

You can use a https://docs.python.org/3/library/shelve.html instead which won't give you issues but then you miss out how easy it is to read the local JSON file.

Hope that makes sense!

An example of having some logic which always force a `_dumps()` call is here https://git.vvvvvvaria.org/decentral1se/xbotlib/src/commit/fa80d094a7ed13b3cb210dcb227116d571326a7e/xbotlib.py#L559. I think if you have a `db = SimpleDatabase()` and then you do `db['a'] = []` and then `db['a'].append(1)` then the `.append` doesn't trigger a `_dumps()` call. You have to do it yourself. You can use a https://docs.python.org/3/library/shelve.html instead which won't give you issues but then you miss out how easy it is to read the local JSON file. Hope that makes sense!

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: varia/multifeeder#2