Run the style checker over the source.

app/__init__.py

@@ -1,14 +1,11 @@
+import os
+from os import environ
+
+from dotenv import find_dotenv, load_dotenv
 from flask import Flask
+from flask_socketio import SocketIO
 from flask_sqlalchemy import SQLAlchemy
-from marshmallow import Schema, fields, ValidationError, pre_load
-from flask_socketio import SocketIO, emit
-from os import environ
-from dotenv import load_dotenv, find_dotenv
-import os
-import click
-from werkzeug.utils import secure_filename
 from sqlalchemy.dialects import registry
-# import flask_whooshalchemyplus not using whoosh anymore
 
 registry.register("rqlite.pyrqlite", "sqlalchemy_rqlite.pyrqlite", "dialect")
 
@@ -16,23 +13,21 @@ basedir = os.path.abspath(os.path.dirname(__file__))
 
 UPLOAD_FOLDER = os.path.join(basedir, 'uploads')
 UPLOAD_FOLDER_COVER = os.path.join(basedir, 'cover')
-#ALLOWED_EXTENSIONS = set(['txt', 'pdf', 'png', 'jpg', 'jpeg', 'gif'])
+
 load_dotenv(find_dotenv())
 app = Flask(__name__)
 
 app.config['SECRET_KEY'] = 'super secret key'
-#app.config['SQLALCHEMY_DATABASE_URI'] = 'sqlite:////tmp/mydatabase.db'
 app.config['UPLOAD_FOLDER'] = UPLOAD_FOLDER
 app.config['SQLALCHEMY_DATABASE_URI'] = 'rqlite+pyrqlite://localhost:4001/'
 app.config['DEBUG'] = True
 app.config['PORT'] = 80
 
-#app.config['SQLALCHEMY_DATABASE_URI'] = 'sqlite:///' + os.path.join(basedir, 'mydatabase.db')
 db = SQLAlchemy(app)
 light = not os.path.isdir(UPLOAD_FOLDER)
 DOMAIN = environ.get('DOMAIN')
 socketio = SocketIO(app)
 
 app.config.from_object(__name__)
-from app import views
 
+from app import views  # noqa

app/cover.py

@@ -1,11 +1,11 @@
+import io
+
 import PyPDF2
-from wand.image import Image
 from wand.color import Color
-import io
-import os
+from wand.image import Image
 
 
-def pdf_page_to_png(src_pdf, pagenum = 0, resolution = 72,):
+def pdf_page_to_png(src_pdf, pagenum=0, resolution=72):
     """
     Returns specified PDF page as wand.image.Image png.
     :param PyPDF2.PdfFileReader src_pdf: PDF from which to take pages.
@@ -19,7 +19,7 @@ def pdf_page_to_png(src_pdf, pagenum = 0, resolution = 72,):
     dst_pdf.write(pdf_bytes)
     pdf_bytes.seek(0)
 
-    img = Image(file = pdf_bytes, resolution = resolution)
+    img = Image(file=pdf_bytes, resolution=resolution)
     img.background_color = Color('white')
     img.alpha_channel = 'remove'
     img.convert("jpeg")
@@ -32,36 +32,32 @@ def get_cover(file_path, filename):
     # ====
     print(file_path)
     src_filename = file_path
+
     try:
         src_pdf = PyPDF2.PdfFileReader(open(src_filename, "rb"))
-    except:
+    except Exception:
         print("couln't open PDF")
-        return None;
+        return
+
     if src_pdf.isEncrypted:
         try:
             src_pdf.decrypt('')
-        except:
+        except Exception:
             print("couln't decrypt")
-            return None;
-    # What follows is a lookup table of page numbers within sample_log.pdf and the corresponding filenames.
+            return
+
+    # What follows is a lookup table of page numbers within sample_log.pdf and
+    # the corresponding filenames.
     pages = [{"pagenum": 0,  "filename": filename}]
 
     # Convert each page to a png image.
     for page in pages:
         big_filename = "app/cover/"+page["filename"] + "_cover.jpeg"
-        #small_filename = "app/cover/"+page["filename"] + "cover_small" + ".jpeg"
 
-        img = pdf_page_to_png(src_pdf, pagenum = page["pagenum"], resolution = 130)
-        #img.save(filename = big_filename)
+        img = pdf_page_to_png(src_pdf, pagenum=page["pagenum"], resolution=130)
 
         # Ensmallen
         img.transform("", "250")
-        img.save(filename = big_filename)
+        img.save(filename=big_filename)
 
     return page["filename"] + "_cover.jpeg"
-
-#---
-#epub
-#https://ebooks.stackexchange.com/questions/6517/command-line-extraction-of-metadata-title-author-from-epub-file
-#https://hackage.haskell.org/package/epub-tools
-#http://stackoverflow.com/questions/9751475/extract-cover-image-from-chm-and-epub-files

app/extractText.py

@@ -2,22 +2,22 @@ import PyPDF2
 
 
 def get_text(file_path, filename):
-    read_pdf =file_path
+    read_pdf = file_path
+    write_txt = "app/uploads/" + filename + '.txt'
 
-    with open(read_pdf,'rb') as pdf_file, open("app/uploads/"+filename+'.txt', 'w') as text_file:
+    with open(read_pdf, 'rb') as pdf_file, open(write_txt, 'w') as text_file:
         read_pdf = PyPDF2.PdfFileReader(pdf_file)
         number_of_pages = read_pdf.getNumPages()
-        for page_number in range(number_of_pages):   # use xrange in Py2
+        for page_number in range(number_of_pages):
             page = read_pdf.getPage(page_number)
             page_content = page.extractText()
             text_file.write(page_content)
 
 
-
 def extract_text(file_path, filename):
     try:
         get_text(file_path, filename)
-    except:
-        with open(filename+'.txt', 'w') as text_file:
+    except Exception:
+        with open(filename + '.txt', 'w') as text_file:
             page_content = ""
             text_file.write(page_content)

app/forms.py

@@ -1,11 +1,11 @@
+from app.models import Author
 from flask_wtf import FlaskForm
-from wtforms import StringField, FileField, validators
-from wtforms.validators import InputRequired, DataRequired
-from wtforms import FieldList
+from wtforms import FieldList, FileField
 from wtforms import Form as NoCsrfForm
-from wtforms.fields import StringField, FormField, SubmitField, SelectField, RadioField
-from app.models import Book, BookSchema, Author, Stack, StackSchema
+from wtforms import validators
+from wtforms.fields import FormField, SelectField, StringField, SubmitField
 from wtforms.fields.html5 import DecimalRangeField
+from wtforms.validators import DataRequired, InputRequired
 
 
 # - - - Forms - - -
@@ -13,11 +13,19 @@ class AuthorForm(NoCsrfForm):
     # this forms is never exposed so we can user the non CSRF version
     author_name = StringField('Author Name', validators=[DataRequired()])
 
+
 class UploadForm(FlaskForm):
     title = StringField('title', validators=[InputRequired()])
-    author = FieldList(FormField(AuthorForm, default=lambda: Author()), min_entries=1)
+    author = FieldList(
+        FormField(AuthorForm, default=lambda: Author()),
+        min_entries=1
+    )
     category = StringField('category', validators=[InputRequired()])
-    year_published = StringField('year published', [validators.Length(max=4)],default=None)
+    year_published = StringField(
+        'year published',
+        [validators.Length(max=4)],
+        default=None
+    )
     file = FileField()
     upload = SubmitField(label='Upload')
     wish = SubmitField(label='''I don't have the file, but wish I did.''')
@@ -26,7 +34,7 @@ class UploadForm(FlaskForm):
     diversity = DecimalRangeField('diversity', default=0)
     gender = DecimalRangeField('gender', default=50)
     choices = [('Student', 'Student'),
-                ('Librarian', 'Librarian'),
+               ('Librarian', 'Librarian'),
                ('Pirate', 'Pirate'),
                ('Teacher', 'Teacher'),
                ('Institution', 'Institution'),
@@ -37,16 +45,23 @@ class UploadForm(FlaskForm):
 
 class EditForm(FlaskForm):
     title = StringField('title', validators=[InputRequired()])
-    author = FieldList(FormField(AuthorForm, default=lambda: Author()), min_entries=1)
+    author = FieldList(
+        FormField(AuthorForm, default=lambda: Author()),
+        min_entries=1
+    )
     category = StringField('category', validators=[InputRequired()])
-    year_published = StringField('year published', [validators.Length(max=4)],default=None)
+    year_published = StringField(
+        'year published',
+        [validators.Length(max=4)],
+        default=None
+    )
     file = FileField()
     message = StringField('message')
     sameness = DecimalRangeField('sameness', default=0)
     diversity = DecimalRangeField('diversity', default=0)
     gender = DecimalRangeField('gender', default=50)
     choices = [('Student', 'Student'),
-                ('Librarian', 'Librarian'),
+               ('Librarian', 'Librarian'),
                ('Pirate', 'Pirate'),
                ('Teacher', 'Teacher'),
                ('Institution', 'Institution'),
@@ -54,26 +69,37 @@ class EditForm(FlaskForm):
                ('None of the above', 'None of the above')]
     who = SelectField('', choices=choices, default='Student')
 
+
 class ChatForm(FlaskForm):
     message = StringField('message', validators=[InputRequired()])
     send = SubmitField(label='Send')
 
+
 class StackForm(FlaskForm):
     stack_name = StringField('Stack', validators=[InputRequired()])
-    stack_description = StringField('Description', validators=[InputRequired()])
+    stack_description = StringField(
+        'Description',
+        validators=[InputRequired()]
+    )
     stack_author = StringField('Who made this', validators=[InputRequired()])
     create = SubmitField(label='Create')
 
+
 class AddtoStackForm(FlaskForm):
     select_stack = SelectField('Stacks', validators=[InputRequired()])
 
+
 class EditStackForm(FlaskForm):
     edit_stack_name = StringField('Stack', validators=[InputRequired()])
-    edit_stack_description = StringField('Description', validators=[InputRequired()])
+    edit_stack_description = StringField(
+        'Description',
+        validators=[InputRequired()]
+    )
+
 
 class SearchForm(FlaskForm):
     choices = [('All', 'All'),
-                ('Title', 'Title'),
+               ('Title', 'Title'),
                ('Author', 'Author'),
                ('Category', 'Category'),
                ('Stack', 'Stack'),

app/getannot.py

@@ -1,61 +1,87 @@
-from flask import request
-import requests
 import json
 
+import requests
+
+from flask import request
+
+
 def get_annotations():
-	KEY = "6879-n8AksBoSB7kYoQ3eEwzpEr3nFQEmSp3XN-0PcKL_Sik"
-
-	#a dictionary containing necessary http headers
-	headers = {
-	    "Host": "hypothes.is",
-	"Accept": "application/json",
-	"Authorization": "Bearer %s" % KEY
-	} 
-
-	base_url = "https://hypothes.is/api/search?user=xpub@hypothes.is"
-
-	search_url = "".join([base_url])
-
-	r = requests.get(search_url, headers=headers)
-	#data is a python dictionary 
-	data = json.loads(r.text)
-	server = request.host
-	for row in data['rows']:
-		row['uri']= row['uri'].replace('http://' + server+'/uploads/','') 
-	return data
-
-
-def get_annot_results(annot,name):
-	res=[]
-	annot=get_annotations()
-	for item in annot['rows']:
-		if 'selector' in item['target'][0]:
-			if len(item['target'][0]['selector'])>2:
-				if name in item['text'] or name in item['target'][0]['selector'][2]['exact']:
-					data={'text': item['text'],'extract':item['target'][0]['selector'][2]['exact'],'title':item['document']['title'], 'url':item['uri']}
-					res.append(data)
-			else:
-				if name in item['text'] or name in item['target'][0]['selector'][1]['exact']:
-					data={'text': item['text'],'extract':item['target'][0]['selector'][1]['exact'],'title':item['document']['title'], 'url':item['uri']}
-					res.append(data)
-	return res
-
-def get_annot_book(annot,name):
-	res=[]
-	server = request.host
-	for item in annot['rows']:
-		if 'selector' in item['target'][0]:
-			if len(item['target'][0]['selector'])>2:
-				string=item['uri']
-				if name==string.replace('http://' + server+'/uploads/',''):
-					data={'text': item['text'],'extract':item['target'][0]['selector'][2]['exact'],'title':item['document']['title'], 'url':item['uri']}
-					res.append(data)
-			else:
-				string=item['uri']
-				if name==string.replace('http://' + server+'/uploads/',''):
-					data={'text': item['text'],'extract':item['target'][0]['selector'][1]['exact'],'title':item['document']['title'], 'url':item['uri']}
-					res.append(data)
-	return res
+    # TODO(decentral1se): remove this from the source
+    KEY = "6879-n8AksBoSB7kYoQ3eEwzpEr3nFQEmSp3XN-0PcKL_Sik"
+
+    # a dictionary containing necessary http headers
+    headers = {
+        "Host": "hypothes.is",
+        "Accept": "application/json",
+        "Authorization": "Bearer %s" % KEY
+    }
+
+    base_url = "https://hypothes.is/api/search?user=xpub@hypothes.is"
+
+    search_url = "".join([base_url])
+
+    r = requests.get(search_url, headers=headers)
+
+    # data is a python dictionary
+    data = json.loads(r.text)
+    server = request.host
+
+    for row in data['rows']:
+            row['uri'] = row['uri'].replace(
+                'http://' + server + '/uploads/',
+                ''
+            )
+
+    return data
+
 
+def get_annot_results(annot, name):
+    res = []
+    annot = get_annotations()
+    for item in annot['rows']:
+        if 'selector' in item['target'][0]:
+            if len(item['target'][0]['selector']) > 2:
+                exact_second = item['target'][0]['selector'][2]['exact']
+                if name in item['text'] or name in exact_second:
+                    data = {
+                        'text': item['text'],
+                        'extract': item['target'][0]['selector'][2]['exact'],
+                        'title': item['document']['title'], 'url': item['uri']
+                    }
+                    res.append(data)
+            else:
+                exact_first = item['target'][0]['selector'][1]['exact']
+                if name in item['text'] or name in exact_first:
+                    data = {
+                        'text': item['text'],
+                        'extract': item['target'][0]['selector'][1]['exact'],
+                        'title': item['document']['title'], 'url': item['uri']
+                    }
+                    res.append(data)
+    return res
 
 
+def get_annot_book(annot, name):
+    res = []
+    server = request.host
+    for item in annot['rows']:
+        if 'selector' in item['target'][0]:
+            if len(item['target'][0]['selector']) > 2:
+                string = item['uri']
+                if name == string.replace('http://' + server+'/uploads/', ''):
+                    data = {
+                        'text': item['text'],
+                        'extract': item['target'][0]['selector'][2]['exact'],
+                        'title': item['document']['title'], 'url': item['uri']
+                    }
+                    res.append(data)
+            else:
+                string = item['uri']
+                if name == string.replace('http://' + server+'/uploads/', ''):
+                    data = {
+                        'text': item['text'],
+                        'extract': item['target'][0]['selector'][1]['exact'],
+                        'title': item['document']['title'], 'url': item['uri']
+                    }
+                    res.append(data)
+    return res

app/models.py

@@ -1,54 +1,99 @@
-from app import db
-from marshmallow import Schema, fields, ValidationError, pre_load
 import datetime
-from sqlalchemy import Column, Integer, DateTime
-import flask_whooshalchemyplus
-
 
-authors = db.Table('books_authors',
-    db.Column('book_id', db.Integer, db.ForeignKey('books.id'), primary_key=True),
-    db.Column('author_id', db.Integer, db.ForeignKey('authors.id'), primary_key=True)
+from app import db
+from marshmallow import Schema, ValidationError, fields
+from sqlalchemy import Column, DateTime
+
+
+authors = db.Table(
+    'books_authors',
+    db.Column(
+        'book_id',
+        db.Integer,
+        db.ForeignKey('books.id'),
+        primary_key=True
+    ),
+    db.Column(
+        'author_id',
+        db.Integer,
+        db.ForeignKey('authors.id'),
+        primary_key=True
+    )
 )
 
-stacks = db.Table('books_stacks',
-    db.Column('book_id', db.Integer, db.ForeignKey('books.id'), primary_key=True),
-    db.Column('stack_id', db.Integer, db.ForeignKey('stacks.id'), primary_key=True)
+stacks = db.Table(
+    'books_stacks',
+    db.Column(
+        'book_id',
+        db.Integer,
+        db.ForeignKey('books.id'),
+        primary_key=True
+    ),
+    db.Column(
+        'stack_id',
+        db.Integer,
+        db.ForeignKey('stacks.id'),
+        primary_key=True
+    )
 )
 
-instances = db.Table('books_instances',
-    db.Column('book_id', db.Integer, db.ForeignKey('books.id'), primary_key=True),
-    db.Column('instance_id', db.Integer, db.ForeignKey('instances.id'), primary_key=True)
+instances = db.Table(
+    'books_instances',
+    db.Column(
+        'book_id',
+        db.Integer,
+        db.ForeignKey('books.id'),
+        primary_key=True
+    ),
+    db.Column(
+        'instance_id',
+        db.Integer,
+        db.ForeignKey('instances.id'),
+        primary_key=True
+    )
 )
 
+
 class Book(db.Model):
     __tablename__ = 'books'
 
-    id = db.Column(db.Integer, primary_key = True)
+    id = db.Column(db.Integer, primary_key=True)
     title = db.Column(db.String(255))
     file = db.Column(db.String(255))
     cover = db.Column(db.String(255))
     fileformat = db.Column(db.String(255))
     category = db.Column(db.String(255))
-    year_published = db.Column(db.Numeric(4,0))
+    year_published = db.Column(db.Numeric(4, 0))
     description = db.Column(db.String(2500))
     html = db.Column(db.String(255))
-    downloads = db.Column(db.Numeric(100,0))
-    authors = db.relationship('Author', secondary=authors,cascade="delete", lazy='subquery',
-        backref=db.backref('books', lazy=True),passive_deletes=True)
-    stacks = db.relationship('Stack', secondary=stacks, lazy='subquery',
-    backref=db.backref('books', lazy=True))
-    instances = db.relationship('Instance', secondary=instances, lazy='subquery',
-    backref=db.backref('books', lazy=True))
-    scapeX = db.Column(db.Numeric(10,2))
-    scapeY = db.Column(db.Numeric(10,2))
+    downloads = db.Column(db.Numeric(100, 0))
+    authors = db.relationship(
+        'Author',
+        secondary=authors,
+        cascade="delete",
+        lazy='subquery',
+        backref=db.backref('books', lazy=True),
+        passive_deletes=True
+    )
+    stacks = db.relationship(
+        'Stack', secondary=stacks, lazy='subquery',
+        backref=db.backref('books', lazy=True)
+    )
+    instances = db.relationship(
+        'Instance', secondary=instances, lazy='subquery',
+        backref=db.backref('books', lazy=True)
+    )
+    scapeX = db.Column(db.Numeric(10, 2))
+    scapeY = db.Column(db.Numeric(10, 2))
     message = db.Column(db.String(1000))
     sameness = db.Column(db.Numeric())
     diversity = db.Column(db.Numeric())
     gender = db.Column(db.Numeric())
     who = db.Column(db.String(255))
 
-
-    def __init__(self, title, file, cover, fileformat, category, year_published, message, sameness, diversity, gender, who):
+    def __init__(self, title, file, cover, fileformat,
+                 category, year_published, message,
+                 sameness, diversity, gender, who):
         self.title = title
         self.file = file
         self.cover = cover
@@ -64,7 +109,6 @@ class Book(db.Model):
         self.gender = gender
         self.who = who
 
-
     def __repr__(self):
         return '<Title %r>' % self.title
 
@@ -81,6 +125,7 @@ class Author(db.Model):
     def __init__(self, author_name):
         self.author_name = author_name
 
+
 class Instance(db.Model):
     __tablename__ = 'instances'
 
@@ -106,6 +151,7 @@ class UserIns(db.Model):
         self.title = title
         self.info = info
 
+
 class Chat(db.Model):
     __tablename__ = 'chat'
 
@@ -117,14 +163,15 @@ class Chat(db.Model):
         self.message = message
         self.time = datetime.datetime.now()
 
+
 class Stack(db.Model):
     __tablename__ = 'stacks'
-    id = db.Column(db.Integer, primary_key = True)
+
+    id = db.Column(db.Integer, primary_key=True)
     stack_name = db.Column(db.String(50))
     stack_description = db.Column(db.String(1000))
     stack_author = db.Column(db.String(255))
 
-
     def __init__(self, stack_name, stack_description, stack_author):
         self.stack_name = stack_name
         self.stack_description = stack_description
@@ -136,7 +183,7 @@ class Stack(db.Model):
 
 class Potential(db.Model):
     __tablename__ = 'potential'
-    id = db.Column(db.Integer, primary_key = True)
+    id = db.Column(db.Integer, primary_key=True)
     ptitle = db.Column(db.String(50))
     time = db.Column(DateTime, default=datetime.datetime.now())
 
@@ -149,16 +196,19 @@ class AuthorSchema(Schema):
     id = fields.Int(dump_only=True)
     author_name = fields.Str()
 
+
 class StackSchema(Schema):
     id = fields.Int(dump_only=True)
     stack_name = fields.Str()
     stack_description = fields.Str()
 
+
 class ChatSchema(Schema):
     id = fields.Int(dump_only=True)
     message = fields.Str()
     time = fields.DateTime()
 
+
 class BookSchema(Schema):
     id = fields.Int(dump_only=True)
     title = fields.Str()